Fix black action arguments + formatting#9
Merged
ianhi merged 3 commits intomatplotlib:mainfrom May 25, 2022
Merged
Conversation
Collaborator
|
This is great thanks! Also in #8 I've added a pre-commit config which could obsolete the lint action. what do you think? |
Collaborator
These are distinct changes so let's not do that. |
Member
Author
|
Probably not experienced enough to have strong opinions on this. Regarding pre-commit I personally have some issues running it on Windows due to being too lazy to set it up properly (develop using conda, but doing git using the bash-prompt from Git for Windows, so they do not have the same Python environments). Running it on the CI is a different thing though. |
Collaborator
|
sorry this dropped off my radar. looks good thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems like black has changed the argument handling. I got this on my newly create repo:
https://black.readthedocs.io/en/stable/integrations/github_actions.html gives the changes in this PR.
srcis not really required since.is the default, but I included it for clarity in case someone want to change it later.The second commit fixes two issues that black points out in the generated code.
Edit: third commit fixes doc formatting.
Let me know if I should squash these into a single commit. Updating as I go along making my project pass the tests with the default setup.